Refactor SimplicialComplex.add_simplex function
#359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 37 37
Lines 3543 3543
=======================================
Hits 3450 3450
Misses 93 93 ☔ View full report in Codecov by Sentry. |
ffl096
force-pushed
the
frantzen/refactor-add-simplex-function
branch
from
919c831
to
13ac77e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the implementation of
SimplicialComplex.add_simplexa bit simpler and allows to introduce changes more easily in the future.Along the way, an inconsistency when providing a
Simplexclass with attributes and additionalkwargsin different cases was fixed.